[Feature] FiniteMPOHamiltonian compression#312
Merged
Conversation
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
force-pushed
the
mpo-compression
branch
from
4704fd2 to
3bbf163
Compare
VictorVanthilt
approved these changes
Sep 1, 2025
Member
VictorVanthilt
left a comment
VictorVanthilt
left a comment
There was a problem hiding this comment.
Other than the small comment this is good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of the algorithm described in Parker et al, which allows compression of MPOHamiltonian objects without ruining the
JordanMPOTensorstructure.There are still some questions about implementation details, tests and docs, and I would like to at least at the reference somewhere before merging, but I already wanted to add this here so people might start playing around with it.
Also, I would like to add the infinite version as well.
Importantly, this keeps the
JordanMPOTensorstructure but ruins the sparsity, so this is not in general something we always want to do. However, especially when working with quasi-2D systems, often terms of the formXiXi+1andX_iX_i+Lappear and can be efficiently compressed, which is not something that our MPO construction scheme would naturally do.This implementation is loosely based on some reference code that I received some time ago by @LHerviou.
See also #311